[docker] fix for devbox docker image root-user build #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
approved these changes
Feb 14, 2024
| @@ -5,7 +5,8 @@ RUN apt-get update | |||
| RUN apt-get -y install bash binutils git xz-utils wget sudo | |||
|
|
|||
| # Step 2: Installing Nix | |||
| RUN wget --output-document=/dev/stdout https://nixos.org/nix/install | sh -s -- --daemon | |||
| RUN mkdir -p /etc/nix/ | |||
| RUN echo "filter-syscalls = false" >> /etc/nix/nix.conf && wget --output-document=/dev/stdout https://nixos.org/nix/install | sh -s -- --daemon | |||
There was a problem hiding this comment.
nit: split into 2 RUN commands for readability (or format so it's one command per line using \)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fix is due to customer message in discord mentioning the launcher having old version.
Nix installation in
docker-image-build-publishworkflow was failing for root-user mode.This PR fixes it.
The fix was based on recommendation from LnL7/nix-docker#41 (comment)
How was it tested?
https://github.com/jetpack-io/devbox/actions/runs/7893709911