[direnv] Fix version path, run example tests on PRs #832
Conversation
.github/workflows/cli-tests.yaml
Outdated
| # This is an optimization that runs tests twice, with and without | ||
| # the examples. We can require non-example tests to complete before | ||
| # merging, while keeping the others as an additional non-required signal | ||
| run-example-tests: [true] |
There was a problem hiding this comment.
I don't quite follow how the code here leads to:
require non-example tests to complete before
# merging, while keeping the others as an additional non-required signal
would you mind explaining, please?
There was a problem hiding this comment.
I changed the matrix strategy to one that is simpler to read. The general logic is:
In PRs run tests with and without examples. Only the non-example one is blocking. We can further improve this in the future by making the examples test only run examples and nothing else.
In main only run tests with examples.
There was a problem hiding this comment.
thanks, it makes more sense now.
Only the non-example one is blocking.
Where is this logic enabled?
There was a problem hiding this comment.
cc @mikeland86 still curious about this question ^^
Summary
This fixed a bad path (was missing root dir) when writing
.devbox/versionfile.I also changed out cli-tests so that it runs example tests in PRs (but we should not require them)
How was it tested?
tests