-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong shell profile in install script message #94
Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't work for me. I used nixery to create a container with zsh + curl + other tools, and it still printed out the bash install instructions....because there was no $SHELL
environment variable.
How did you test this?
richard@LAPTOP-HJEQ9V9G:~$ docker run --rm -it nixery.dev/curl/gnutar/gzip/coreutils/zsh zsh -c 'curl -fsSL https://raw.githubusercontent.com/jetstack/jsctl/fix_typo_install_script/install.sh | zsh'
######################################################################## 100.0%
jsctl was installed successfully to //.jsctl/bin/jsctl
Manually add the directory to your $HOME/.bashrc (or similar)
export JSCTL_INSTALL="//.jsctl"
export PATH="$JSCTL_INSTALL/bin:$PATH"
And run "source //.bashrc" to update your current shell
Run '//.jsctl/bin/jsctl --help' to get started
Checkout https://platform.jetstack.io/documentation for more information
Found some more info here: https://stackoverflow.com/questions/3327013/how-to-determine-the-current-interactive-shell-that-im-in-command-line
|
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@wallrj This issue should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I retested and could see it working.
docker run --rm -it nixery.dev/curl/gnutar/gzip/coreutils/zsh zsh -c 'export HOME=/tmp; curl -fsSL https://raw.githubusercontent.com/jetstack/jsctl/fix_typo_install_script/install.sh | zsh; echo export JSCTL_INSTALL="/tmp/.jsctl" >> /tmp/.zshrc; echo export PATH="$JSCTL_INSTALL/bin:$PATH" >> /tmp/.zshrc; source /tmp/.zshrc; cat /tmp/.zshrc; jsctl '
/lgtm
fixes #93