URI compliance modes for #6001 #6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parators default modes allows both ambiguous separators and segments, but still forbids ambiguous parameters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
…-ambiguous-uris Fix #6001 separate compliance modes for ambiguous URI segments, params and separators
Signed-off-by: gregw <gregw@webtide.com>
Fixed checkstyle
gregw
changed the title
Improve names
Improved javadoc
|
@sbordet I've updated the names and the javadoc |
sbordet
requested changes
Feb 25, 2021
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/UriCompliance.java
Outdated
Show resolved
Hide resolved
updates after review
sbordet
reviewed
Feb 25, 2021
| private static final AtomicInteger __custom = new AtomicInteger(); | ||
|
|
||
| public static UriCompliance valueOf(String name) | ||
| { | ||
| for (UriCompliance compliance : KNOWN_MODES) | ||
| for (UriCompliance compliance : Arrays.asList(DEFAULT, LEGACY, RFC3986, STRICT, SAFE)) |
There was a problem hiding this comment.
Why not using EnumSet.allOf() or similar?
There was a problem hiding this comment.
Because they are not enums! They are just static final fields.
They were enums in 9, but that meant users could not define their own modes, so we have the CUSTOM[0-4] hack there.
sbordet
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the HttpCompliance changes of #6003 and #6002 for #6001 to a new UriCompliance class, changing default to SAFE