Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(semantic-release): add build step to release job #19

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

marlosin
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our conventions
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Semantic release job is failing because it is configured to read dist so running build script is pre-requisite.

What is the new behavior?

build script runs before semantic-release script.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@marlosin marlosin requested a review from KutsenkoA June 19, 2020 07:48
@marlosin marlosin self-assigned this Jun 19, 2020
@marlosin marlosin merged commit cf65300 into master Jun 19, 2020
@marlosin marlosin deleted the fix/semantic-release branch June 19, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants