Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): issue with publishing the package #20

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

marlosin
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our conventions
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The latest attempt to publish to npm failed because angular ivy compiled libs aren't allowed. tsconfig.json was properly set, but angular.json needed to point to it for production build

What is the new behavior?

Added tsconfig configuration to angular.json

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@marlosin marlosin requested a review from KutsenkoA June 29, 2020 16:38
@marlosin marlosin self-assigned this Jun 29, 2020
@marlosin marlosin merged commit 20060a0 into master Jun 30, 2020
@marlosin marlosin deleted the fix/npm-publish branch June 30, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants