Allow getMessage to also pass objects to custom defaultMessageCreator. #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a small feature request to allow objects to be passed to
defaultMessageCreator
that would help our use case quite significantly.To keep a long story short we're internationalizing our validation messages with react-intl by reimplementing the validators we need and passing a custom
defaultMessageCreator
tocreateValidator
that returns an object instead of a string.However when trying to internationalize the
field
parameter passed todefaultMessageCreator
we run into an issue where only strings are accepted but the internationalization API requires an object consisting ofid
anddefaultMessage
.This PR fixes that by allowing
config.field
to be an object while hopefully maintaining backwards compatibility.Let me know if there's anything blocking this from being merged.
Best regards, Simon.