Reinstate dec/inc integral optimisation #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfalcou
force-pushed
the
feat/optimize-masked-inc-dec
branch
from
9d083f6
to
1029262
Compare
jfalcou
force-pushed
the
feat/optimize-masked-inc-dec
branch
from
c115f30
to
13a0d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masked dec and inc on integral values with wide logical can be optimized to be branchless/if_else less by addign or substarcting the mask as an integer itself.
This was an optimization we had long ago and that disappeared through one of our recent refactoring and was pointerd out to me during my recent tutorial workshop at the LAPP.
This PR resinstates those optimisations.