Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed \ to fn for lambda declaration #70

Merged
merged 1 commit into from
Apr 18, 2021
Merged

changed \ to fn for lambda declaration #70

merged 1 commit into from
Apr 18, 2021

Conversation

mkhan45
Copy link
Contributor

@mkhan45 mkhan45 commented Apr 18, 2021

This is a really clean codebase!

A few things that would make contributing easier:

  • Document how the goldentests work
  • Add cargo fmt rules to a rustfmt.toml or just disable it completely (just add ignore = ["/"] to rustfmt.toml at the repo root)

Copy link
Owner

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good :)

I agree with your points on making contributing easier, I think I'll make a Contributing wiki page so that I can expand that section with information on goldentests and possibly a FAQ in the future without cluttering the README too much.

I'll explore some cargo formatting rules too, I'm still stuck in the mindset of manually formatting things but even if I don't mind some formatting inconsistencies it does seem easier for contributors in the future to contribute with the ease of mind their formatting is acceptable.

@jfecher jfecher merged commit 7f5c24f into jfecher:master Apr 18, 2021
@jfecher
Copy link
Owner

jfecher commented Apr 18, 2021

I went ahead and updated #67 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants