Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Prefer repo from settings over project #90

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Dec 6, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

In CI mode, when a resolution server is specified, the plugin should prioritize repository settings configured by the user in the JFrog CLI / Jenkins Artifactory plugin over those in the build.gradle file. For example, configuring the Gradle project with jf gradlec --server-id-resolve maven-remote and executing jf gradle clean aP should result in the use of the maven-remote repository instead of any repositories mentioned in the build.gradle file.

@yahavi yahavi self-assigned this Dec 6, 2023
@yahavi yahavi added improvement Automatically generated release notes safe to test Approve running tests on a pull request labels Dec 6, 2023
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Dec 6, 2023
@yahavi yahavi changed the title CI mode - Prefer repo from settings over project CI - Prefer repo from settings over project Dec 6, 2023
@yahavi yahavi requested review from eyalbe4 and removed request for eyalbe4 December 6, 2023 15:03
@yahavi yahavi added the safe to test Approve running tests on a pull request label Dec 6, 2023
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Dec 6, 2023
@yahavi yahavi requested a review from eyalbe4 December 6, 2023 15:37
Copy link

github-actions bot commented Dec 6, 2023

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@yahavi yahavi added bug Something isn't working and removed improvement Automatically generated release notes labels Dec 11, 2023
@yahavi yahavi merged commit 7f4be71 into jfrog:main Dec 11, 2023
12 checks passed
@yahavi yahavi deleted the ci-prefer-settings branch December 11, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Username must not be null!" with Gradle in Artifactory plugin version 4.0.0
2 participants