Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maven home parsing for paths with whitespaces #159

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix Maven home parsing for paths with whitespaces #159

merged 1 commit into from
May 15, 2023

Conversation

sverdlov93
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

For example: Maven home: C:\Program Files\Maven\apache-maven-3.9.1

following jfrog/jfrog-azure-devops-extension#412

@sverdlov93
update
3121811 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the bug Something isn't working label May 7, 2023
yahavi
yahavi approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phenomenal!

@sverdlov93 sverdlov93 changed the base branch from main to dev May 15, 2023 14:09
@sverdlov93 sverdlov93 merged commit f900259 into jfrog:dev May 15, 2023
@yahavi yahavi mentioned this pull request May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@sarao1310 sarao1310 Awaiting requested review from sarao1310

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @yahavi