Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xray server support GKE ingress controller with health probes #154

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

eldada
Copy link
Contributor

@eldada eldada commented Dec 18, 2018

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated

What this PR does / why we need it:
Change the Xray server health probes to look at /web so they'll return a 200 and not 300.
This helps supporting running with a GKE ingress controller.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #149

Copy link
Collaborator

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jainishshah17 jainishshah17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jainishshah17 jainishshah17 merged commit bd1c3a8 into master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE ingress controller will failed with "unhealthy" backend because of the Readiness Probe Path
3 participants