Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local Git operations tests #345

Merged
merged 105 commits into from
Jul 3, 2023
Merged

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented May 24, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Summary:
Added local Git operation tests to:

  • Scan pull request:

    • Verify we are not scanning the same branch ( will return an error ), will help figure out miss-configurations.
  • CreateFixPullReuqests:

    • Verifies the creation of a new branches and the diff in the dependency files.
    • Verifies Aggregate \ Non-Aggregate fixes
  • Fix undeleted tmp folders

Full Description:
During the execution of the scan-pull-request command, our tests failed to verify the scanning of two distinct branches. To address this issue and ensure proper functionality, this pull request introduces tests that specifically validate the scanning of separate branches. If such a scenario occurs, an error will be triggered to alert the user, as this issue often arises due to misconfigurations.

Also, improved tests to use local gits which will allow us to test the creation of branches and other git operations.

@EyalDelarea EyalDelarea added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels May 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 24, 2023
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label May 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 24, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label May 24, 2023
@EyalDelarea EyalDelarea requested a review from eyalbe4 May 24, 2023 13:42
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 24, 2023
@EyalDelarea EyalDelarea changed the title Add new tests to make sure diffs on pull request Verify scanning pull requests prerequisites May 24, 2023
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label May 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 24, 2023
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jun 29, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 29, 2023
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jun 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 30, 2023
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jul 2, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 2, 2023
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jul 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023


  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jul 3, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023


  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@EyalDelarea EyalDelarea merged commit 8fd980e into jfrog:dev Jul 3, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants