Convert SSH clone urls to HTTPS #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
omerzi
suggested changes
Jun 12, 2023
commands/utils/params.go
Outdated
| // Endpoint should empty for default values or start with https scheme. | ||
| func verifyValidApiEndpoint(endpoint *string) error { | ||
| if *endpoint != "" && !strings.HasPrefix(*endpoint, "https://") { | ||
| return errors.New("missing api endpoint scheme") |
There was a problem hiding this comment.
You need to utilize ErrMissingEnv here. Returning a regular error will fail the process. Note that we don't want to fail on an empty ApiEndpoint because, in such cases, froggit-go automatically inserts the default API endpoint for each git provider.
commands/utils/git.go
Outdated
Comment on lines
360
to
374
| func (gm *GitManager) generateHTTPSCloneUrl() (url string, err error) { | ||
| switch gm.git.GitProvider { | ||
| case vcsutils.GitHub: | ||
| return fmt.Sprintf(githubHttpsFormat, gm.git.RepoOwner, gm.git.RepoName), nil | ||
| case vcsutils.GitLab: | ||
| return fmt.Sprintf(gitLabHttpsFormat, gm.git.GitProject, gm.git.RepoName), nil | ||
| case vcsutils.BitbucketServer: | ||
| return fmt.Sprintf(bitbucketServerHttpsFormat, gm.git.ApiEndpoint, gm.git.RepoOwner, gm.git.RepoName), nil | ||
| case vcsutils.AzureRepos: | ||
| return fmt.Sprintf(azureDevopsHttpsFormat, gm.git.RepoOwner, gm.git.RepoOwner, gm.git.GitProject, gm.git.RepoName), nil | ||
| default: | ||
| return "", fmt.Errorf("unsupported version control provider: %s", gm.git.GitProvider.String()) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This would not work for on-premises. We need to support such cases based on the given ApiEndpoint. We can fallback to the cloud format if the ApiEndpoint is empty.
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
omerzi
suggested changes
Jun 12, 2023
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain Git repos remote urls are defined as SSH.
Frogbot uses
JF_GIT_ACCESStoken with sufficient permissions so we don't need to add other auth method, just to replace the remote urls from SSH to HTTPS.