Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logs and logos #379

Merged
merged 30 commits into from
Jul 20, 2023
Merged

Improve logs and logos #379

merged 30 commits into from
Jul 20, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jul 4, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@omerzi omerzi added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Jul 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 4, 2023
yahavi
yahavi reviewed Jul 4, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 4, 2023
@omerzi omerzi requested a review from eyalbe4 July 4, 2023 12:53
@omerzi omerzi marked this pull request as ready for review July 4, 2023 12:53
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@omerzi omerzi temporarily deployed to frogbot July 5, 2023 10:29 — with GitHub Actions Inactive
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

@omerzi omerzi requested a review from sverdlov93 July 6, 2023 06:37
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 9, 2023
@yahavi yahavi mentioned this pull request Jul 9, 2023
Closed
3 tasks
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@omerzi
Merge remote-tracking branch 'upstream/dev' into improve-logs-and-logos
100a284 
# Conflicts:
#	commands/createfixpullrequests.go
#	commands/testdata/scanpullrequest/expectedResponseMultiDir.json
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@omerzi omerzi merged commit 58ef270 into jfrog:dev Jul 20, 2023
6 of 7 checks passed
@github-actions
Copy link
Contributor

@omerzi omerzi deleted the improve-logs-and-logos branch July 23, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi left review comments

@sverdlov93 sverdlov93 sverdlov93 approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omerzi @yahavi @sverdlov93