Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregated pull requests with multi project/working dirs #386

Merged
merged 28 commits into from
Jul 23, 2023
Merged

Fix aggregated pull requests with multi project/working dirs #386

merged 28 commits into from
Jul 23, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jul 11, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Based on: jfrog/froggit-go#98

  • Fix using aggregated fixing pull request with multiple projects/workings dirs
  • Refactor create-fix-pull-request
  • Added tests

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 11, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 12, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 13, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 13, 2023
@omerzi omerzi marked this pull request as ready for review July 13, 2023 11:39
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@omerzi omerzi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@github-actions
Copy link
Contributor

sverdlov93
sverdlov93 reviewed Jul 20, 2023
View reviewed changes
commands/createfixpullrequests.go Outdated Show resolved Hide resolved
commands/createfixpullrequests.go Outdated Show resolved Hide resolved
commands/testdata/createfixpullrequests/aggregate-multi-project/.frogbot/frogbot-config.yml Show resolved Hide resolved
commands/utils/utils.go Outdated Show resolved Hide resolved
commands/utils/utils.go Outdated Show resolved Hide resolved
commands/createfixpullrequests_test.go Show resolved Hide resolved
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 23, 2023
@omerzi omerzi merged commit ecc49ca into jfrog:dev Jul 23, 2023
1 check failed
@github-actions
Copy link
Contributor

@omerzi omerzi deleted the fix-aggregated-prs branch July 23, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @sverdlov93