Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pnpm support #656

Merged
merged 26 commits into from
Mar 24, 2024
Merged

Add Pnpm support #656

merged 26 commits into from
Mar 24, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Mar 10, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Introducing support in Pnpm package manager for 'scan-repository' and 'scan-pr'!
depends on:
jfrog/jfrog-cli-security#41
jfrog/jfrog-cli-core#1150

Note: The failing Package Handlers tests are due to changes in test.yml workflow. The tests were verified locally and on a fork:
Screenshot 2024-03-24 at 13 50 32

Screenshot 2024-03-24 at 13 51 12

@eranturgeman eranturgeman marked this pull request as draft March 10, 2024 10:44
@eranturgeman eranturgeman added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Mar 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 18, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 20, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 20, 2024
omerzi
omerzi suggested changes Mar 21, 2024
View reviewed changes
packagehandlers/commonpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/commonpackagehandler.go Show resolved Hide resolved
packagehandlers/commonpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/commonpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/commonpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/pnpmpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/pnpmpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/pnpmpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/pnpmpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/pnpmpackagehandler.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 24, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman merged commit bec8bb4 into jfrog:dev Mar 24, 2024
27 of 30 checks passed
@eranturgeman eranturgeman mentioned this pull request Mar 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi requested changes

@attiasas attiasas Awaiting requested review from attiasas

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @omerzi