Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Java version in test.yml to v11 #703

Merged
merged 5 commits into from
May 23, 2024
Merged

Fixing Java version in test.yml to v11 #703

merged 5 commits into from
May 23, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented May 23, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Tests in my fork:
Screenshot 2024-05-23 at 14 01 37

Screenshot 2024-05-23 at 14 02 04

Screenshot 2024-05-23 at 14 02 22

@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels May 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2024
@eranturgeman eranturgeman changed the title Fixing Java version in test.yml to v17 Fixing Java version in test.yml to v11 May 23, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit 93d52a6 into jfrog:dev May 23, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @attiasas