-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add technology to audit params if provided by user through 'install' command #749
Merged
eranturgeman
merged 11 commits into
jfrog:dev
from
eranturgeman:pass-tech-to-aduit-if-install-command-provided
Sep 15, 2024
Merged
Add technology to audit params if provided by user through 'install' command #749
eranturgeman
merged 11 commits into
jfrog:dev
from
eranturgeman:pass-tech-to-aduit-if-install-command-provided
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was provided by the user
eranturgeman
temporarily deployed
to
frogbot
September 11, 2024 13:25
— with
GitHub Actions
Inactive
eranturgeman
added
bug
Something isn't working
safe to test
Approve running integration tests on a pull request
labels
Sep 11, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
eranturgeman
had a problem deploying
to
frogbot
September 11, 2024 14:04
— with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
eranturgeman
had a problem deploying
to
frogbot
September 11, 2024 14:38
— with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
eranturgeman
temporarily deployed
to
frogbot
September 11, 2024 15:08
— with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 11, 2024
…-to-aduit-if-install-command-provided
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 06:43
— with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 07:12
— with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
attiasas
reviewed
Sep 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, take a look at my comment
eranturgeman
had a problem deploying
to
frogbot
September 15, 2024 13:11
— with
GitHub Actions
Failure
…-to-aduit-if-install-command-provided
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 18:02
— with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 18:32
— with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
eranturgeman
temporarily deployed
to
frogbot
September 15, 2024 19:55
— with
GitHub Actions
Inactive
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Audit parameters to include a specified technology from the install command, if provided.
This change leverages a new enhancement introduced here: jfrog/jfrog-cli-security#175
In that improvement, we enhanced the technology detection when an install command is provided, allowing Frogbot to better handle complex structures where technologies are incorrectly identified. For instance, in a Yarn project with several sub-projects (not in a multi-module setup), where the sub-projects only have a package.json file without other Yarn indicators, these sub-projects are mistakenly identified as NPM projects.
This fix addresses that issue by enabling tech detection using descriptors when an install command is provided, rather than relying solely on indicators (which we typically use to avoid collisions between technologies with similar descriptors, like Yarn and NPM). If an install command is specified along with the working directories to scan (via frogbot-config.yml), we enforce this technology on each of the directories and use descriptors alone for verification, resolving the issue described.