Create Build Evidence. #16
Conversation
evidence/create_build.go
Outdated
| build string | ||
| } | ||
|
|
||
| func NewCreateEvidenceBuild(serverDetails *coreConfig.ServerDetails, predicateFilePath string, predicateType string, key string, keyId string, |
There was a problem hiding this comment.
Optional: as the types are the same, the string may be put just once:
func NewCreateEvidenceBuild(serverDetails *coreConfig.ServerDetails,
predicateFilePath, predicateType, key, keyId, project, build string) Command {
| } | ||
|
|
||
| func (c *createEvidenceBuild) buildBuildInfoSubjectPath(artifactoryClient artifactory.ArtifactoryServicesManager) (string, error) { | ||
| build := strings.Split(c.build, ":") |
There was a problem hiding this comment.
Please, raise the question about the input parameters one more time.
This split means that neither Build Name nor Build Number may contain : (this is not the case).
Hence, it means that we do not support Builds with name/number having :.
Needs to be confirmed explicitly.
There was a problem hiding this comment.
I talked with Noam, there is a chance to change all other operations to be splitter to --name --version.
will take it in a separate Jira ticket.
evidence/create_build.go
Outdated
| BuildNumber: number, | ||
| ProjectKey: project, | ||
| } | ||
| res, b, err := artifactoryClient.GetBuildInfo(buildInfo) |
There was a problem hiding this comment.
Please, rename b to something like ok.
evidence/create_build.go
Outdated
| res, b, err := artifactoryClient.GetBuildInfo(buildInfo) | ||
| if !b { | ||
| errorMessage := fmt.Sprintf("failed to find build, name:%s, number:%s, project: %s", name, number, project) | ||
| if err != nil { |
There was a problem hiding this comment.
The order of conditions looks wrong, the err should be checked first:
if err != nil {
return "", err
}
if !ok {
errorMessage := fmt.Sprintf("failed to find build, name:%s, number:%s, project: %s", name, number, project)
return "", errorutils.CheckErrorf(errorMessage)
}
|
Create Evidence Build-Info Using CLI |
No description provided.