Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Phase 3 progress wrongly adds transferred files #1059

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Dec 5, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

There's an issue that needs fixing:

image

Steps to reproduce
Execute jf rt transfer-files twice. The second run will show incorrect progress in Phase 3.

The root cause
Phase 3 doesn't retain information, yet it fetches the count of transferred files from the prior run.

@yahavi yahavi added the bug Something isn't working label Dec 5, 2023
@yahavi yahavi requested a review from eyalbe4 December 5, 2023 13:11
@yahavi yahavi self-assigned this Dec 5, 2023
@eyalbe4 eyalbe4 changed the title Transfer - Phase 3 progress add transferred files Transfer - Phase 3 progress wrongly adds transferred files Dec 11, 2023
@yahavi yahavi merged commit 63a81ae into jfrog:dev Dec 11, 2023
7 of 8 checks passed
@yahavi yahavi deleted the fix-phase-3-progress branch December 11, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants