Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Make high frequency changes atomic #1061

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Dec 6, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Concurrent updates to state variables in certain scenarios can lead to inaccuracies, causing unexpected behaviors. An instance highlighting this concern involves a "negative" value within the "Delayed files" category:

image

The objective of this pull request is to improve accuracy by adjusting these values using the native atomic package.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@yahavi yahavi merged commit d092f02 into jfrog:dev Dec 11, 2023
7 of 8 checks passed
@yahavi yahavi deleted the atomic branch December 11, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants