-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sha256 for Xray's DBSyncV3 files to be downloaded #1070
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We're adding tests to ensure the code works as expected, regardless of whether the functionality has an external affect or not.
- Testing this porperly is super easy. No extra logic what so ever. Simply have a function that returns the log output as a string, and then test its output. The tests table should include all cases.
I've extracted getting the filename string to a different function and changed the test to check that returned string. |
No description provided.