Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "unknown/unknown" module id for docker attestations #1223

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Aug 6, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Docker attestations do not have a specified platform, so we cannot construct the module ID based on it.
This fix creates a dedicated module for Docker attestations.

@RobiNino RobiNino added the bug Something isn't working label Aug 6, 2024
artifactory/utils/container/buildinfo.go Outdated Show resolved Hide resolved
artifactory/utils/container/buildinfo.go Outdated Show resolved Hide resolved
artifactory/utils/container/buildinfo.go Show resolved Hide resolved
@RobiNino RobiNino merged commit 2563a5d into jfrog:dev Aug 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants