Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle npm version prefix #197

Merged
merged 5 commits into from
Aug 8, 2021
Merged

Handle npm version prefix #197

merged 5 commits into from
Aug 8, 2021

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Jul 29, 2021 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Cannot rely on --json output of npm pack because of npm/cli#3405

@RobiNino RobiNino requested a review from eyalbe4 July 29, 2021 12:29
@RobiNino RobiNino mentioned this pull request Jul 29, 2021
Merged
3 tasks
eyalbe4
eyalbe4 requested changes Aug 7, 2021
View reviewed changes
artifactory/commands/npm/publish.go Show resolved Hide resolved
artifactory/commands/npm/publish.go Outdated Show resolved Hide resolved
utils/npm/version.go Outdated Show resolved Hide resolved
utils/npm/version.go Outdated Show resolved Hide resolved
utils/npm/version.go Outdated Show resolved Hide resolved
@RobiNino RobiNino merged commit 6b8e6de into jfrog:dev Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @eyalbe4