Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix - npm audit should not calculate checksums #358

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Bugfix - npm audit should not calculate checksums #358

merged 2 commits into from
Mar 21, 2022

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Mar 20, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on jfrog/build-info-go#71
Fixes jfrog/jfrog-cli#1475

@yahavi yahavi requested review from eyalbe4 and Or-Geva March 20, 2022 12:43
@yahavi yahavi self-assigned this Mar 20, 2022
@yahavi yahavi mentioned this pull request Mar 20, 2022
Closed
@yahavi yahavi merged commit f6d192a into jfrog:dev Mar 21, 2022
@yahavi yahavi deleted the npm-no-sha branch March 21, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@Or-Geva Or-Geva Awaiting requested review from Or-Geva

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4