Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade go-pretty fix empty audit table results in CircleCI #2345

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Downgrade go-pretty fix empty audit table results in CircleCI #2345

merged 7 commits into from
Dec 4, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Dec 4, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Downgrade go-pretty from v6.4.8 to v6.4.0

related to: jfrog/jfrog-cli-core#1045

@attiasas attiasas added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Dec 4, 2023
@attiasas attiasas requested a review from yahavi December 4, 2023 15:21
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@yahavi yahavi added bug Something isn't working and removed ignore for release Automatically generated release notes labels Dec 4, 2023
@attiasas attiasas changed the title Update indirect dependencies Downgrade go-pretty fix empty audit table results in CircleCI Dec 4, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@attiasas attiasas merged commit a4a837a into jfrog:dev Dec 4, 2023
63 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @yahavi