Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows signing #2463

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Update Windows signing #2463

merged 2 commits into from
Mar 4, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Mar 4, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@yahavi yahavi requested a review from eyalbe4 March 4, 2024 15:38
@yahavi yahavi self-assigned this Mar 4, 2024
@yahavi yahavi added the improvement Automatically generated release notes label Mar 4, 2024
eyalbe4
eyalbe4 requested changes Mar 4, 2024
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
@yahavi yahavi merged commit e019c95 into jfrog:dev Mar 4, 2024
11 of 14 checks passed
@yahavi yahavi deleted the update-sign branch March 4, 2024 16:17
@BrewTestBot BrewTestBot mentioned this pull request Mar 5, 2024
Merged
@yahavi yahavi added improvement Automatically generated release notes and removed improvement Automatically generated release notes labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4