Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the 'jf rt atc' command #2477

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Deprecate the 'jf rt atc' command #2477

merged 1 commit into from
Mar 14, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Mar 14, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

The /artifactory/api/security/token endpoint is deprecated in Artifactory.
Deprecate jf rt atc and suggest using jf atc instead. jf atc is using the /access/api/v1/tokens API.

./jf rt atc
10:54:27 [🟠Warn] You are using a deprecated syntax of the command.
	Instead of:
	$ jf rt atc ...
	Use:
	$ jf atc ...

Downside - The jf atc does not support basic auth:

./jf atc
10:55:03 [🚨Error] authenticating with access token is currently mandatory for creating access tokens

@yahavi yahavi added the improvement Automatically generated release notes label Mar 14, 2024
@yahavi yahavi requested a review from eyalbe4 March 14, 2024 09:01
@yahavi yahavi self-assigned this Mar 14, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@yahavi yahavi requested a review from RobiNino March 14, 2024 11:07
@yahavi yahavi merged commit dbbc8a8 into jfrog:dev Mar 14, 2024
77 of 79 checks passed
@yahavi yahavi deleted the deprecate-rtatc branch March 14, 2024 12:48
@StephenWithPH
Copy link

@yahavi I'm seeing other bad behavior regarding auth (similar to your comment above) with jf atc now that it has replaced jf rt atc. For example, #2490 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants