Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check docker API version instead of version #623

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Check docker API version instead of version #623

merged 3 commits into from
Mar 10, 2020

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Mar 9, 2020 •
edited
Loading

  • I signed JFrog's CLA.
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR is targeting: jfrog/setup-jfrog-cli#8

In this PR, I rely on the API version structure of Major.Minor provided in the docker official documentation.

@yahavi yahavi requested review from eyalbe4 and Or-Geva March 9, 2020 15:14
@yahavi yahavi self-assigned this Mar 9, 2020
@yahavi yahavi mentioned this pull request Mar 9, 2020
Closed
@yahavi yahavi merged commit 5b924af into jfrog:dev Mar 10, 2020
@yahavi yahavi deleted the fix-docker-version branch March 10, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Or-Geva Or-Geva Or-Geva approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @Or-Geva