Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unite http content type header code #996

Merged
merged 31 commits into from
Aug 6, 2024
Merged

Unite http content type header code #996

merged 31 commits into from
Aug 6, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Aug 6, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Converted AddHeader to a method and united content type json usages:
image

sverdlov93 and others added 24 commits July 25, 2024 13:58
@sverdlov93
docker repo build info
32f3ee9 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' into buildinfo-repo
d172324
@sverdlov93
Merge branch 'dev' into buildinfo-repo
9c0ffa2
@sverdlov93
improve
cc6ad62 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge remote-tracking branch 'sverdlov93/buildinfo-repo' into buildin…
0dcbcc4 
…fo-repo
@sverdlov93
improve
b61f6e3 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
revert minsplitsize
cb70b6a 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-client-go into b…
cacad6c 
…uildinfo-repo
@sverdlov93
avoid panic
38691cd 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
avoid panic
b975559 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-client-go into b…
b635796 
…uildinfo-repo
@sverdlov93
Use gofrog's crypto
5420ea0 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' into buildinfo-repo
8e733d2
@sverdlov93
Use gofrog's crypto
df7fe9b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge remote-tracking branch 'sverdlov93/buildinfo-repo' into buildin…
9fe0795 
…fo-repo

# Conflicts:
#	go.mod
#	go.sum
@sverdlov93
Use gofrog's crypto
416227c 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
3af9d79 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
788a707 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
ffaf1b6 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-client-go into b…
919eacf 
…uildinfo-repo
@sverdlov93
Use gofrog's crypto
dced36b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
4d8401e 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
447f7c1 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-client-go into b…
18b0827 
…uildinfo-repo
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Aug 6, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@sverdlov93
Use gofrog's crypto
5d468b3 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
e4cec47 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
c5381e4 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@sverdlov93
Use gofrog's crypto
52825a7 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
b0cb8bc 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
7db285f 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Aug 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 6, 2024
RobiNino
RobiNino requested changes Aug 6, 2024
View reviewed changes
artifactory/services/props.go Outdated Show resolved Hide resolved
@sverdlov93
Use gofrog's crypto
24dd64b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit 01bb7dc into jfrog:dev Aug 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobiNino RobiNino RobiNino requested changes

@yahavi yahavi Awaiting requested review from yahavi

@omerzi omerzi Awaiting requested review from omerzi

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @RobiNino