Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Korean and Simplified Chinese to languages #22

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

movsesyanpv
Copy link
Contributor

Korean and Simplified Chinese are missing from current version of the wrapper, but supported by the Bungie's API.

Copy link
Owner

@jgayfer jgayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Is this documented somewhere? Or is it only returned from the endpoint to fetch available locales?

README.md Outdated Show resolved Hide resolved
@movsesyanpv
Copy link
Contributor Author

It is returned from the endpoint .

Current response from it is

{
    "Response": {
        "German": "de",
        "English": "en",
        "Spanish": "es",
        "SpanishMexican": "es-mx",
        "French": "fr",
        "Italian": "it",
        "Japanese": "ja",
        "Korean": "ko",
        "Polish": "pl",
        "Portuguese": "pt-br",
        "Russian": "ru",
        "ChineseSimplified": "zh-chs",
        "ChineseTraditional": "zh-cht"
    },
    "ErrorCode": 1,
    "ThrottleSeconds": 0,
    "ErrorStatus": "Success",
    "Message": "Ok",
    "MessageData": {}
}

Co-authored-by: James Gayfer <gayfer.james@gmail.com>
Copy link
Owner

@jgayfer jgayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jgayfer jgayfer merged commit 2617666 into jgayfer:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants