Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCT-1251 Add gunicorn app #98

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

MrCreosote
Copy link
Member

No description provided.

@jayrbolton
Copy link

why not put that in src/jgikbase/idmapping?
otherwise looks good

@coveralls
Copy link

Pull Request Test Coverage Report for Build 208

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.05%

Totals Coverage Status
Change from base Build 207: 0.0%
Covered Lines: 1037
Relevant Lines: 1091

💛 - Coveralls

@MrCreosote
Copy link
Member Author

MrCreosote commented Aug 15, 2018

I actually just copied how you set up the caching service where the app was in the root. Do you think that's not a good idea?

See https://github.com/kbase/CachingService/blob/master/app.py

@MrCreosote MrCreosote merged commit 259938b into jgi-kbase:dev-prototype Aug 15, 2018
@jayrbolton
Copy link

For your repo, it might be more consistent, and is slightly less prone to namespace conflict
In my repo, I wasn't concerned with namespace conflicts and didn't have any problems. I just put it in the root out of simplicity/laziness. I might nest things better in that repo soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants