Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pip and python 3 #1

Merged
merged 3 commits into from
Nov 17, 2018
Merged

fix pip and python 3 #1

merged 3 commits into from
Nov 17, 2018

Conversation

johannjacobsohn
Copy link
Contributor

  1. Geonum cannot be installed atm, adding the appropriate Manifest file fixes that issue.
$ pip install --user geonum

Collecting geonum
  Using cached https://files.pythonhosted.org/packages/07/5c/690435f33dcd8905df4edcb99c16835fd8d528420dff99ce74cb62ae89a5/geonum-1.3.1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-oKoXlR/geonum/setup.py", line 12, in <module>
        with open("VERSION.rst") as f:
    IOError: [Errno 2] No such file or directory: 'VERSION.rst'
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-oKoXlR/geonum/
  1. The handling of comparing None to a number (eg. with the < operator) has changed between python 2 and 3 (returning false vs raising exception). Two commits to fix the bug and add a test case reproducing the issue.

@jgliss jgliss merged commit 5c188d7 into jgliss:master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants