-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support accesskey like Wikipedia #609
Comments
For reference, what English Wikipedia supports is described at https://en.wikipedia.org/wiki/Wikipedia:Keyboard_shortcuts |
I haven't written Haskell in quite some time, so bare with me. As an example, "edit" links on English Wikipedia use key e as <a href="/w/index.php?title=Main_Page&action=edit" title="This page is protected.
You can view its source [Alt+Shift+e]" accesskey="e"><span>View source</span></a> In Gitit, the "edit" links have gitit/src/Network/Gitit/Layout.hs Lines 146 to 153 in eed3263
It seems that it uses the function |
HTML attribute `accesskey` [1] allows user to quickly navigate the website. Add support for `accesskey` to links of Gitit using the shortcut scheme of MediaWiki [2]. This would allow users who edit MediaWiki websites to more easily navigate Gitit webpages. Closes jgm#609 [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey [2] Documented in detail on English Wikipedia, one of the main instances of MediaWiki: https://en.wikipedia.org/wiki/Wikipedia:Keyboard_shortcuts See also https://www.mediawiki.org/wiki/Manual:Access_keys and https://meta.wikimedia.org/wiki/Help:Keyboard_shortcuts
The$tabs$ generated by gitit are unfortunately not editable via tempates/ so I'm filing this as a bug.
Please add the accesskey attribute to the default HTML generated by gitit, along the lines Wikipedia does it:
The text was updated successfully, but these errors were encountered: