Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no warnings given when tables with merged cells fail to convert #2783

Closed
jamesrharwood opened this issue Mar 14, 2016 · 8 comments
Closed

no warnings given when tables with merged cells fail to convert #2783

jamesrharwood opened this issue Mar 14, 2016 · 8 comments

Comments

@jamesrharwood
Copy link

E.g. When I convert the attached docx file, pandoc deletes columns 2 and 3 without warning me. It would be useful to get a warning.
example_table_with_merged_cells.docx

@jgm
Copy link
Owner

jgm commented Mar 18, 2016

@jkr now that you've integrated warnings into the docx reader, it should be fairly simple to issue a warning in this case. Or have you already added that, too?

@jkr
Copy link
Collaborator

jkr commented Mar 18, 2016

No -- I just haven't had a chance to look through the xml in detail to
figure out how they do merged horizontal cells, and merged vertical.

I also think the deletion is the result of some shortcuts I take in the
current implementation that force the table to be the width of the first
row. I have a feeling that if I looked closely, I could avoid losing
some data as well.

John MacFarlane notifications@github.com writes:

[ text/plain ]
@jkr now that you've integrated warnings into the docx reader, it should be fairly simple to issue a warning in this case. Or have you already added that, too?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2783 (comment)

@Sen-Sai
Copy link

Sen-Sai commented May 26, 2020

So it would be really great if a warning could be given!
We convert docx to mediawiki markup for about 10 documents a day, but merged cells is losing content and that is a big problem. I know you are working on this, but a warning for the older versions of pandoc would still be a good option

@jgm
Copy link
Owner

jgm commented May 28, 2020

I tried the docx in the original post with the current dev version of pandoc, and no columns are lost.

I'm sorry, we don't backport changes to older versions. But it looks like things are already fixed?

@jgm
Copy link
Owner

jgm commented May 28, 2020

When cells are being merged, though, I agree that a warning should be issued.

@Sen-Sai
Copy link

Sen-Sai commented Jun 2, 2020

I'm sorry, we don't backport changes to older versions. But it looks like things are already fixed?

Reason I mentioned that is because hosting companies do not very often upgrade their *nix version or PHP version resulting in the fact that as a user you are stuck with certain versions of pandoc.

@jgm
Copy link
Owner

jgm commented Jun 3, 2020

You can always install the static linux binary we provide, which should work just about everywhere.

@tarleb
Copy link
Collaborator

tarleb commented May 28, 2021

Commit 56b2111 added support for colspans and rowspans to the docx reader, so this should be fixed now.

@tarleb tarleb closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants