Binary reference files build system #2014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: No idea why travis failed, but this has little to do with changes proposed here... |
|
@lierdakil Travis fails because of #2013 which depends on jgm/highlighting-kate#64 It would be fixed until either a new |
|
@ShabbyX, apparently, there is a new version of |
|
@lierdakil yes, John was a step ahead of us |
|
Triggered a rebuild by reopening PR. Let's see if it works now. |
|
This looks good. But when I tried to compile your branch, it didn't quite work. When I tried to open the generated files I switched back to master, and found that So, I think a recent commit involving this must have broken it. I'm not sure about the odt, because the reference.odt in master opens just fine, so maybe there is some additional problem with your build script. |
|
More on this: the error I have in master when I try to open |
|
Clue: I see the problem, and I've got the fix. - archive <-
- getDirectoryContents "."
- >>= addFilesToArchive [OptRecursive] emptyArchive
+ archive <- addFilesToArchive [OptRecursive] emptyArchive ["."]I'll go ahead and merge this with this change. |
|
I have pushed these changes. Closing. Will open a new issue about the footnote issue in reference.docx. |
|
Thank you. And sorry about the mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in https://groups.google.com/forum/#!topic/pandoc-discuss/i9lconsh0yw
What it is:
A simple cabal post-build hook that zip-archives unpacked data for
data/reference.docxanddata/reference.odt. No additional dependencies, should work on all target platforms.Why:
I firmly believe this will greatly simplify working with reference files for binary formats, since most of the work on these is done by-hand anyway (to my experience, that is). As an added benefit, it offers proper revision-tracking, instead of "binary file differs".
All relevant code is in lierdakil/pandoc@4d1267a.