Add pagebreaks to Pandoc #3230
Open
Add pagebreaks to Pandoc #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp-lshift
pushed a commit
to lshift-de/typesetr2
that referenced
this pull request
Nov 15, 2016
Added to check that our change in Pandoc that adds page breaks (PR jgm/pandoc#3230) leads to correctly formatted .tex documents.
|
I wonder this could be implemented using the FORM FEED character for textual output formats. |
This requires an updated version of pandoc-types that introduces PageBreak definition. Not that this initial commit only introduces ODT pagebreaks and distinguishes for it page breaks before, after, or both, the paragraph, as read from the style definition.
Update all writers to take into account page breaks. A straightforwad, far from complete, implementation of page breaks in selected writers. Readers will have to follow in the future as well.
hubertp-lshift
force-pushed
the
feature/pagebreaks
branch
from
92bb7e5
to
0d43370
Compare
|
@wilx for the purpose of latex/odt, maybe. I didn't try it. But I think pagebreaks is such a common (and desired) feature that it deserves its own definition for the purpose of other readers/writers. |
|
@hubertp-lshift I've merged this into the typeclass branch (which will become pandoc 2.0). However, I'm not sure it's right for PageBreak to be an Inline element. It seems more appropriate as a Block. Can you comment on why you chose to make it an Inline? (This may be more natural in ODT, but we should also consider other output formats.) |
|
I've reverted this. It needs more thought and discussion. |
|
The place for discussion is probably #1934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first stab at adding pagebreaks to Pandoc. Fully implemented for ODT (reader & writer).
Also added a few other writers, when the underlying format supported them out of the box.
Depends on jgm/pandoc-types#28