Add tectonic as an option for --pdf-engine. #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mb21
reviewed
Mar 3, 2019
jgm
reviewed
Mar 3, 2019
jgm
reviewed
Mar 3, 2019
jgm
reviewed
Mar 3, 2019
jgm
reviewed
Mar 3, 2019
src/Text/Pandoc/PDF.hs
Outdated
| "-output-directory", tmpDir] ++ args ++ [file] | ||
| let programArgs | takeBaseName program == "latexmk" = ["-interaction=batchmode", "-halt-on-error", "-pdf", | ||
| "-quiet", "-outdir=" ++ tmpDir] ++ args ++ [file] | ||
| | takeBaseName program == "tectonic" = args ++ [file] -- outdir defaults to dir of input file |
There was a problem hiding this comment.
One question is what tectonic will put in the output dir. The pandoc policy is not to leave any files on the file system that the user didn't explicitly request (e.g. with -o myfile.pdf).
There was a problem hiding this comment.
The answer to that one is nothing.
It has extra flags that optionally enable writing aux files into the output dir (which is, as the comment says, the temp directory in this case), but it never needs them, that’s only so you can speed up reprocessing with the Makefiles it also knows how to generate.
cormacrelf
force-pushed
the
master
branch
4 times, most recently
from
4f3af3b
to
5dd217c
Compare
Closes jgm#5345 - runs tectonic on STDIN instead of a temporary .tex file, so that it looks in PWD for \include and \input like the rest of the engines. - allows overriding the output directory without messing up the args with `--pdf-engine-opt=--outdir --pdf-engine-opt="$DIR"`
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5345