Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight for CodeBlock of OpenDocument #6716

Closed
wants to merge 2 commits into from
Closed

Syntax highlight for CodeBlock of OpenDocument #6716

wants to merge 2 commits into from

Conversation

niszet
Copy link
Contributor

@niszet niszet commented Oct 4, 2020

By #6711, syntax highlighting for inline Code has been implemented.
Syntax highlighting for CodeBlock is also implemented based on Docx Writer.

  • Paragraph style of CodeBlock is changed from "Preformatted_20_Text" to "Source_Code".
  • As similar to docx writer, CodeBlock is decomposed to "Code + LineBreak" lines.
  • To do this, Code is updated again to treat multiple lines.
  • Styles will be incorpolated by Writer/ODT.hs

Further discussion will be written in #6710.

To implement Syntax highlighting for OpenDocument, inlineToOpenDocument in OpenDocument Writer is updated based on Docx Writer.
This commit is only for inline Code because update of CodeBlock needs structual change of output document.
Currently, styles are not generated automatically in styles.xml. To implement it, additional commit for ODT Writer is needed.
Although styles are not included in styles.xml, output file can be shown in LibreOffice(7.0.0.3) like normal characters.
By #6711, syntax highlighting for inline Code has been implemented.
Syntax highlighting for CodeBlock of OpenDocument is also implemented based on Docx Writer.

* Paragraph style of CodeBlock is changed from "Preformatted_20_Text" to "Source_Code".
* As similar to docx writer, CodeBlock is decomposed to "Code + LineBreak" lines.
* To do this, inlineToOpenDocument for Code is updated again to treat multiple lines.
* Styles will be incorporated by Writer/ODT.hs
@niszet
Copy link
Contributor Author

niszet commented Oct 4, 2020

Sorry, I will send a PR again.

@niszet niszet closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant