Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ePub writer: belongs-to-collection metadata #7063

Merged
merged 3 commits into from
Feb 3, 2021
Merged

ePub writer: belongs-to-collection metadata #7063

merged 3 commits into from
Feb 3, 2021

Conversation

Desbeers
Copy link
Contributor

This is a pull-request to support the belongs-to-collection metadata attribute for ePubs.

See the request on #6199

It adds two fields to the EPUB.hs writer:

  • belongs-to-collection: The name of the collection.
  • group-position: the number of the publication relative in the collection.

When a belongs-to-collection is found; collection-type = "series" will be added as well. I know that that can also be "set" but I never saw that in real-life.

The patch also reformats the other metadata a bit; that's only to keep the source-formatting nice :-)

The two new attributes are also added to the MANUAL.txt.

@jgm
Copy link
Owner

jgm commented Jan 31, 2021

I'm baffled about the CI failure. It is most likely an out of memory error in linking, but why we are getting that now, I don't know. I tried rerunning but to no avail. @tarleb any ideas?

@tarleb
Copy link
Collaborator

tarleb commented Jan 31, 2021

I think the problem is that this was opened when the main branch was failing. Closing and reopening to see if that fixes it.

@tarleb tarleb closed this Jan 31, 2021
@tarleb tarleb reopened this Jan 31, 2021
@jgm jgm merged commit b79aba6 into jgm:master Feb 3, 2021
@jgm
Copy link
Owner

jgm commented Feb 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants