Add rowspan, colspan and alignment to cells in jats table reader #8724
Conversation
src/Text/Pandoc/Readers/JATS.hs
Outdated
|
|
||
| -- How do I parse an Element into Blocks? | ||
| -- parseCell takes an element and returns a StateT JATSState Blocks, but I need it to return the unwrapped value | ||
| let parseCell = parseMixed plain . elContent | ||
|
|
||
| let elementToCell element = cell (toAlignment element) (RowSpan $ toRowSpan element) (ColSpan $ toColSpan element) mempty |
There was a problem hiding this comment.
Here is where I am having trouble. Right now, I'm creating an empty Cell, but I really want to be able to use parseCell to parse the content of the xml cell into the Pandoc cell
There was a problem hiding this comment.
All parsing happens ins the StateT JATSState m type, a.k.a. JATS m. It is an instance of Monad, so we can use cellContent <- parseCell element to "unwrap" the Blocks while we are in a do block, as is the case here.
I could probably free half an hour tomorrow if you want to pair on this.
There was a problem hiding this comment.
Thanks for the quick response @tarleb! Running cellContent <- parseCell element makes sense, but I think what's tripping me up is that I would want to run it in the context of elementToCell, which is not in a do block.
I'd love to do a quick pair! I'm normally available between 8-5 CST (GMT -6), but also wouldn't mind stretching on either end. Let me know when works for you!
There was a problem hiding this comment.
Would 14:30 UTC work for you? If so, please send me an invite via mail.
noahmalmed
force-pushed
the
nm/add_rowspan_colspan_to_jats_parser
branch
from
e72f554
to
d69248e
Compare
Description
I'm looking for some guidance on completing this code change. This is my first time writing Haskell code and I'm getting stuck on some code and I can't tell if my design is wrong/bad or if I'm just missing something syntactically or conceptually.
My issue is arising from trying to parse the xml
Elementattributes at the same time as when we parse the content of theElementitself, so when we create aCell, we have all of the information we need.The previous design of the code just parsed the xml row
Elements intoBlocksand then madesimpleCells (which don't accept rowspan, colspan or alignment attributes) from thoseBlocks.So, I'm getting stuck with a typing/monad issue. I'm able to parse out the
colspan,rowspanandalignmentattributes from the xml and push those values into cells, but I'm having a heard time usingparseMixedto parse anElementintoBlocks.parseMixedreturns the typeStateT JATSState Blocks. What would be an idiomatic way to get theBlocksvalue out of theStateT JATSStatemonad that is returned by this function?I also realize that because I'm new to Haskell and Pandoc that my approach to this problem may be way off base, so any direction there would be welcome as well!