Fix for #8869 in addition to proper handling of quoted header args in Org #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Jun 22, 2023
| <* skipSpaces | ||
| where | ||
| endOfValue = lookAhead $ try (skipSpaces <* oneOf "\n\r") | ||
| <|> try (skipSpaces1 <* orgArgKey) | ||
|
|
||
| quotedValue = char '\"' *> manyTill anyChar (char '\"') | ||
|
|
||
| regularValue = noneOf "\n\r" `many1Till` endOfValue |
There was a problem hiding this comment.
This will parse spaces; is that intended?
The old parser would stop if it gets to spaces followed by an orgArgKey, while this one won't, if I understand correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fixing #8869, this should also properly handle cases such as
which is valid Org but is currently not supported by pandoc.
Note that this is, I believe, the first time I've actually touched Haskell, so feel free to make changes:) But at least my test cases seem to pass nicely now 👍