Correct location of alt-text content #9134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamoe
commented
Oct 13, 2023
| @@ -138,18 +138,16 @@ trimNl = T.dropAround (== '\n') | |||
|
|
|||
| -- function that is used by both graphic (in parseBlock) | |||
| -- and inline-graphic (in parseInline) | |||
| getGraphic :: PandocMonad m | |||
| => Maybe (Inlines, Text) -> Element -> JATS m Inlines | |||
There was a problem hiding this comment.
Noticed this function was only ever called with Nothing as first argument, which means it does not need it. Got rid of this argument and all corresponding logic.
kamoe
commented
Oct 13, 2023
| let altText = case filterElement (named "alt-text") e of | ||
| Just alt -> textContent alt | ||
| Nothing -> mempty | ||
| (ident, title, altText') = (atVal "id", atVal "title", text altText) |
There was a problem hiding this comment.
third argument is actually capturing alt-text, not caption, renamed as such
kamoe
commented
Oct 13, 2023
| Just (capt', i) -> (i, "fig:" <> atVal "title", capt') | ||
| Nothing -> (atVal "id", atVal "title", | ||
| text (atVal "alt-text")) | ||
| let altText = case filterElement (named "alt-text") e of |
There was a problem hiding this comment.
this is where we fetch content from a child, rather than an argument
|
great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JATS reader erroneously attempting to fetch alt-text content from non-existent @alt-text attribute, to optional child element