Don't emit unnecessary classes in HTML tables (#9325)

[ThomasSoeiro]

Here is a try for #9325 according to @jgm guidance :

• The change in the writer needs to be refined but I guess this is the idea.
• I found no use of header/odd/even classes in data/templates/styles.html.
• I removed header/odd/even accross the tests; I'm not sure about changes in update test/command/*.md so I put it in a separate commit.

I also found occurence of odd/even in:

• pandoc-lua-engine/test/sample.lua and pandoc-lua-engine/test/tables.custom
• and /src/Text/Pandoc/Writers/Textile.hs and test/tables.textile

Do they need updating too?

PS: This is my first pull request. It is only WIP but I hope it helps. Otherwise, feel free to close!

[jgm]

Hi @ThomasSoeiro ! I'm really sorry to have let this sit for so long. It must have come in during a busy period and then it was buried. But this all looks good to me, I think you could "undraft" it.

[jgm]

And yes, I'd say those other things should also be updated for consistency.

[ThomasSoeiro]

hi @jgm!

(...) But this all looks good to me, I think you could "undraft" it.

Done, thank you for having a look!

And yes, I'd say those other things should also be updated for consistency.

Sorry, I won't be able to take care of it for several weeks.

[jgm]

Thanks, I'll just merge this and take care of the other thing separately.

[Malcolmnixon]

The removal of odd/even is a bit of a breaking change for us. We were relying on that to produce pretty HTML tables with alternating lines.

It may be possible to use the CSS nth-child(even) trick, but that may not work when the tables are split across pages using something like pagedjs.

[tarleb]

@Malcolmnixon: Lua filter to restore the old behavior:

local function add_odd_even (rows)
  for rownum, row in ipairs(rows) do
    row.classes:insert((rownum % 2) == 0 and 'even' or 'odd')
  end
  return rows
end

function Table (tbl)
  add_odd_even(tbl.head.rows)
  for _, tblbody in ipairs(tbl.bodies) do
    add_odd_even(tblbody.body)
  end
  add_odd_even(tbl.foot.rows)
  return tbl
end