Fedora base #73
Merged
Fedora base #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpine was fun, but maintenance is not that straightforward. Same for musl, so this commit adds a new dockerfile based on Fedora.
Different compiler, different order of includes and support for range loops.
The new fedora image needs the folder to exist, so this commit addresses that.
It worked because it was an error scenario, but "return 0" is not the proper way to exit, and an error was shown. This commit fixes that.
Ssl libs are not produced with the static version anymore, this forces hermes to link dynamically.
The main changes are that now hermes executable is installed and, sue to the new dynamic linking, dynamic libs are also copied.
Pull Request Test Coverage Report for Build 5742163548
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpine was fun, but maintenance is not that straightforward.
Same for musl, so This PR makes all needed adaptations to use fedora as base.