IE fails to redirect to authorize page #52
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when Fandjango redirects a user to authorize the app, it uses a HTTP status code of 303. The body of the response contains the javascript "window.parent.location = "{{ url|safe }}". The response also leaves the Location header blank, which is typically accompanied with a 303.
This works perfectly fine for every browser...except IE. I've no doubt you're as shocked as I am.
So this pull request sets the status code to a 200, a quick and simple fix. Since you have the request you could also try to detect MSIE in the user agent. The code could look something like this:
Let me know what you're thoughts are. Here's a list of IE agents for testing if you're interested: