Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mocks to tests to simulate graph calls. #94

Merged
merged 2 commits into from
Aug 20, 2013

Conversation

ademuk
Copy link
Contributor

@ademuk ademuk commented Aug 18, 2013

  • Fixes all tests.
  • Creates valid signed_request dynamically.
  • Ups tests Django dependency to 1.5.2 to resolve JSONField bug.

Upped to Django 1.5.2 to resolve JSONField bug.
@ademuk
Copy link
Contributor Author

ademuk commented Aug 19, 2013

Hey @jgorset,

Would just like to say great app. You've got the only Django Facebook app which works out of the box, with no hoops to jump through. That takes some thought.

I was looking to add a new middleware to handle non-canvas requests, and in the process wanted to fix your tests so that I knew I wasn't breaking anything.

Could you kindly review, and let me know your thoughts?

@jgorset
Copy link
Owner

jgorset commented Aug 20, 2013

Hi @ademuk,

thanks so much for mocking the tests! I've been wanting to do this for a while, but but seeing as how I mostly do Ruby now I've been less than motivated.

✨ 🍰 ✨

@jgorset jgorset merged commit ffbeab5 into jgorset:master Aug 20, 2013
@jgorset jgorset mentioned this pull request Aug 20, 2013
@ademuk ademuk mentioned this pull request Aug 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants