Fix FANDJANGO_SITE_URL settings attribute #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_post_authorization_redirect_url now checks that FANDJANGO_SITE_URL is set If not defaults to request.get_host()
…O_SITE_URL being absent.
jgorset
added a commit
that referenced
this pull request
Jan 13, 2014
Fix FANDJANGO_SITE_URL settings attribute
|
Thanks, @ademuk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FANDJANGO_SITE_URLis no longer mandatory.FacebookWebMiddlewareifFANDJANGO_SITE_URLis not set, the post auth redirect url will be constructed automatically.Documentation PR: #100
🎉🍸🌟 Happy New Year! 🌟🍸🎉