Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MSK,GMSK. #35

Closed
rnbokade opened this issue Aug 15, 2019 · 8 comments
Closed

Support for MSK,GMSK. #35

rnbokade opened this issue Aug 15, 2019 · 8 comments
Labels
question Generic question about code or usage resolved Issue was resolved (e.g. bug fixed, or feature implemented)

Comments

@rnbokade
Copy link

Docs claim that Semetech chips have capabilities for MSK and GMSK. Can those be invoked using some settings in code?

@jgromes
Copy link
Owner

jgromes commented Aug 17, 2019

You didn't mention whether you mean SX127x or SX126x series, but the answer is pretty much the same for both: What's the source of that information? (G)MSK is only mentioned in passing, and as far as I can tell, there's no way to actually use it.

@rnbokade
Copy link
Author

https://www.semtech.com/products/wireless-rf/lora-transceivers/sx1268
Check in the features section.

@jgromes
Copy link
Owner

jgromes commented Aug 18, 2019

Features section isn't docs - it's advertising. Judging by the actual docs (i.e. datasheet), SX126x either can't do MSK at all, or it is completely undocumented.

@jgromes jgromes closed this as completed Aug 18, 2019
@rnbokade
Copy link
Author

Minimum frequency-shift keying or minimum-shift keying (MSK) is a particular spectrally efficient form of coherent FSK. In MSK, the difference between the higher and lower frequency is identical to half the bit rate. Consequently, the waveforms that represent a 0 and a 1 bit differ by exactly half a carrier period. The maximum frequency deviation is δ = 0.25 fm, where fm is the maximum modulating frequency. As a result, the modulation index m is 0.5. This is the smallest FSK modulation index that can be chosen such that the waveforms for 0 and 1 are orthogonal.
Source :- Wikipedia

@rnbokade
Copy link
Author

So I guess a function beginMSK could be added which in turn can call befinFSK to set the deviation 0.25 times that of bitrate... Later the shaping filter value is already known to set gaussian filter... So GMSk is also solved

@jgromes
Copy link
Owner

jgromes commented Mar 26, 2020

Is there a reason to add it then? Since MSK is just a special case of FSK, I don't see any advantage in implementing a new beginMSK method - it would likely confuse users more than anything.

@rnbokade
Copy link
Author

rnbokade commented Mar 26, 2020 via email

@jgromes
Copy link
Owner

jgromes commented Mar 26, 2020

Again - I'm not sure it's really beneficial. Users that need MSK in their application probably know how to achieve it. Users that don't need it or don't know what it is will only get confused, much like I was at the start of this issue.

@jgromes jgromes added question Generic question about code or usage resolved Issue was resolved (e.g. bug fixed, or feature implemented) labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Generic question about code or usage resolved Issue was resolved (e.g. bug fixed, or feature implemented)
Projects
None yet
Development

No branches or pull requests

2 participants